search

JuliaDocs / DemoCards.jl

Let's focus on writing demos
MIT License
66 stars 14 forks source link

error on build failure #84

Closed johnnychen94 closed 3 years ago

johnnychen94 commented 3 years ago

Currently, demo build failure is suppressed and shown as a warning. For CI/CD purposes, it would be good to explicitly throw an error with perhaps throw_error=true keyword.

The demo script will be executed twice:

The first execution is for the cover generation (I think we can optionally skip this)

https://github.com/johnnychen94/DemoCards.jl/blob/07aa3b70d72e3e3f2332e9d9733c078af69b3a8b/src/types/julia.jl#L145-L146

The second execution is for the Jupyter notebook generation:

https://github.com/johnnychen94/DemoCards.jl/blob/07aa3b70d72e3e3f2332e9d9733c078af69b3a8b/src/types/julia.jl#L170-L175

cc: @findmyway

johnnychen94 commented 3 years ago

closed by #85

A new keyword throw_error = false is added.