JuliaDocs / DocumentationGenerator.jl

MIT License
21 stars 7 forks source link

Don't eval `make.jl` into an anonymous module #199

Closed mortenpi closed 1 year ago

mortenpi commented 1 year ago

https://github.com/JuliaDocs/DocumentationGenerator.jl/blob/2a23ba6ccd8b609d9e5ff099aee491aa2ab098ec/src/rundocumenter.jl#L49

Documenter generally assumes that things are available in Main. This should avoid these types of failure modes:

┌ Error: failed to evaluate `CurrentModule = HDF5.API` in `@meta` block in src/api_bindings.md:5-7
│ ```@meta
│ CurrentModule = HDF5.API
│ ```
│   exception = UndefVarError: `HDF5` not defined
└ @ Documenter.Expanders ~/.julia/packages/Documenter/bYYzK/src/Utilities/Utilities.jl:32