Catppuccin themes - Githubissues

JuliaDocs / Documenter.jl

A documentation generator for Julia.

https://documenter.juliadocs.org

MIT License

812 stars 479 forks source link

Catppuccin themes #2496

Closed fredrikekre closed 4 months ago

fredrikekre commented 5 months ago

This patch adds the four catppuccin themes (https://github.com/catppuccin/catppuccin).

TODO:

[x] The new light theme should present itself as light
[x] Adjust contrast for version and theme selector
[x] Fix color for headers
[x] ANSI color 15 looks strange
[x] Footnotes in dark themes should match the source links of docstrings
[ ] Fix tests

fredrikekre commented 5 months ago

4 new themes here: https://documenter.juliadocs.org/previews/PR2496/

Hetarth02 commented 5 months ago

This is very nice!

A suggestion from my side would be to have somewhere where user can define their own color schemes through variables.

Something like what daisyui and other frameworks does.

mortenpi commented 4 months ago

LGTM!

mortenpi commented 4 months ago

In retrospect, a couple of post-merge thoughts :sweat_smile:

Maybe instead of using shell, we move the templated build logic into DocumenterTools as well, and use Mustache.jl?
It would be good to have the new themes be tested too (i.e. that the CSS is up to date).

fredrikekre commented 4 months ago

Maybe instead of using shell, we move the templated build logic into DocumenterTools as well, and use Mustache.jl?

Yea maybe, but Makefile dependency tracking is pretty nice and if you develop Documenter themes you probably have make? :)

I found it pretty neat to just put make at the top of docs/make.jl in a LiveServer loop while developing this (could of course be done with Julia too).

It would be good to have the new themes be tested too (i.e. that the CSS is up to date).

Sure, I can add a test, but maybe not necessary for the release?