search

JuliaDocs / DocumenterTools.jl

Extra tools for setting up Documenter
Other
30 stars 19 forks source link

ssh-keygen as a jll #36

Closed Nosferican closed 2 years ago

Nosferican commented 4 years ago

Currently the package assumes access to Sys.which and it implies access to the PATH environmental variable which is not always accessible to the environment (e.g., Visual Studio Code on OSX). The better way to implement it would be to have ssh-keygen as a jll.

mortenpi commented 4 years ago

Actually, currently we're using the which (or where on Windows) binary to check for ssh-keygen. Switching to Sys.which would already be an improvement.

But yes, ideally we'd just pull in ssh-keygen as a binary dependency, so that we could guarantee that it would always work. I believe this would require a build of OpenSSH, which I did not see it in Yggdrasil though.

Also, moved this issue to the DocumenterTools repo.

Nosferican commented 4 years ago

Sounds good. Sorry for opening the issue at the wrong repo... I should go to bed already.

aminya commented 4 years ago

I transferred this to https://github.com/aminya/Keygen.jl. We can close it here.