search

JuliaDocs / DocumenterTools.jl

Extra tools for setting up Documenter
Other
30 stars 19 forks source link

bump compat version for Sass #49

Closed Roger-luo closed 3 years ago

Roger-luo commented 3 years ago

not sure why CompatHelper didn't create a PR, perhaps it was disabled by github?

Roger-luo commented 3 years ago

test failure doesn't seem related?

mortenpi commented 3 years ago

It looks like our tests on master are all failing yeah: https://github.com/JuliaDocs/DocumenterTools.jl/runs/2337686982

This PR itself LGTM. One thing to note is that Sass.jl 0.2 only supports Julia 1.3+ (since it uses _jlls), so it would still be using 0.1 on older Julia versions I believe. But that should be fine -- there have been no API changes as far as I can tell.