JuliaDynamics / ABMFrameworksComparison

Benchmarks and comparisons of leading ABM frameworks
Other
13 stars 8 forks source link

Use Int8 instead of Int in Agents.jl ForestFire #63

Closed Tortar closed 1 year ago

Tortar commented 1 year ago

61

Datseris commented 1 year ago

I am not sure if such an optimization makes sense, in the sense that it can be trivially be done across all frameworks and it would have the same impact; here we used Int8 only in Agents.jl. If there is a reason to specify the type of the container we might as well declare it in the decleration file

Tortar commented 1 year ago

I don't think it is true, NetLogo can't specify the type of integers so I think such an optimizations is not possible, Mason and Mesa can't do it too with the current implementation which means that it is not a trivial change in these two frameworks, yet it is true that a better implementation could do it, but it is not trivial to change the model, and at least in Mason I expect that the new implementation would make the model more complex

Tortar commented 1 year ago

So I would instead declare that as you suggested

Datseris commented 1 year ago

it is so crazy sad that such a trivial, simple change as changing the element type of a container is difficult in other frameworks.