search

JuliaDynamics / Agents.jl

Agent-based modeling framework in Julia
https://juliadynamics.github.io/Agents.jl/stable/
MIT License
710 stars 114 forks source link

Move to StreamSampling for sampling agents #1025

Closed Tortar closed 2 months ago

Tortar commented 2 months ago

This is the new name for the package IteratorSampling

Datseris commented 2 months ago

Context? please try to have descriptions in the top post of a PR!

Tortar commented 2 months ago

yes sorry, I just released a new version of the package which I renamed this way and so I updated the code in Agents so that it uses the latest version

Tortar commented 2 months ago

they are actually type instances, they are something like const algR = AlgR() internally, I see both practices in other Julia packages. For the names, thanks for the suggestion and I think the same but these are unfortunately the names in the literature. I will add the prefix about the package though soon

Datseris commented 2 months ago

const algR = AlgR() this doesn't save you any effort overall as the words are the same length, but the reader of the source code then has to also find the extra line const algR = AlgR(). I missed it on the first read through. So, I'd say, just replace everything with StreamSampling.AlgR() etc.

Tortar commented 2 months ago

should be okay now