search

JuliaDynamics / Agents.jl

Agent-based modeling framework in Julia
https://juliadynamics.github.io/Agents.jl/stable/
MIT License
736 stars 119 forks source link

Flocking model video doesn't work after update to Makie 0.21 #1045

Closed Tortar closed 2 months ago

Tortar commented 3 months ago

Look at https://juliadynamics.github.io/Agents.jl/dev/examples/flock/

Datseris commented 3 months ago

almost certainly it is because now makie checks for keyword arguments and throws errors for invalid kwargs. I've had similar problems in other packages. So we just have to be careful with the kwargs we give to makie.

For example, it could be that for mesh scatter, many keywords that we normally propagate to scatter, are invalid.

amynang commented 2 months ago

commenting out the agent_marker argument in abmvideo solves the issue (but agents are now plain circles)

ERROR: Invalid attributes markersize and marker for plot type Poly.

Datseris commented 2 months ago

Thanks @amynang , are you interested to create a PR for this? The issue isn't actually in ambvideo, but in meshscatter (or similar function) used internally deeper in the code.

amynang commented 2 months ago

I'm learning Julia as I'm learning how to use Agents.jl so it might be a while before I can be useful...