JuliaDynamics / Agents.jl

Agent-based modeling framework in Julia
https://juliadynamics.github.io/Agents.jl/stable/
MIT License
725 stars 117 forks source link

Fix wraparound behaviour when r is big #882

Closed Tortar closed 12 months ago

Tortar commented 12 months ago

This fixes #566.

Need tests and the implementation should be simplified.

codecov-commenter commented 12 months ago

Codecov Report

Merging #882 (0e57542) into main (636e709) will increase coverage by 0.25%. The diff coverage is 100.00%.

:exclamation: Current head 0e57542 differs from pull request most recent head d4e0432. Consider uploading reports for the commit d4e0432 to get more accurate results

@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
+ Coverage   72.52%   72.78%   +0.25%     
==========================================
  Files          42       42              
  Lines        2839     2866      +27     
==========================================
+ Hits         2059     2086      +27     
  Misses        780      780              
Files Changed Coverage Δ
src/spaces/grid_general.jl 99.16% <100.00%> (+0.24%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Tortar commented 12 months ago

there is still some sort of bug :D

Datseris commented 11 months ago

I've noticed that this PR did not change documentation. Can you also now please remove the statement we had in the docs that using big r would lead to incorrect results? So that we don't waste documetnation space.

Tortar commented 11 months ago

I searched for it, but I didn't find it, maybe it was removed in some PR