JuliaDynamics / Agents.jl

Agent-based modeling framework in Julia
https://juliadynamics.github.io/Agents.jl/stable/
MIT License
717 stars 115 forks source link

Remove unnecessary check in add_agent_pos! #903

Closed Tortar closed 10 months ago

Tortar commented 10 months ago

This will fail with an easy to bisect error anyway since adding to the model will fail since the agent type will not be accepted. Forgot to do it when merging #900

Tortar commented 10 months ago

wops! sorry renamed one of the files before merging without changing the including statement!!

Tortar commented 10 months ago

For some reason, I can't anymore bypass the protection rule otherwise I would have merged this one already

codecov-commenter commented 10 months ago

Codecov Report

Merging #903 (301d335) into main (fd62258) will increase coverage by 11.88%. Report is 1 commits behind head on main. The diff coverage is 88.50%.

@@             Coverage Diff             @@
##             main     #903       +/-   ##
===========================================
+ Coverage   80.21%   92.09%   +11.88%     
===========================================
  Files          44       33       -11     
  Lines        3028     2329      -699     
===========================================
- Hits         2429     2145      -284     
+ Misses        599      184      -415     
Files Coverage Δ
src/Agents.jl 100.00% <ø> (ø)
src/core/higher_order_iteration.jl 83.33% <ø> (ø)
src/core/model_single_container.jl 90.00% <100.00%> (ø)
src/core/space_interaction_API.jl 93.18% <100.00%> (+0.10%) :arrow_up:
src/simulations/collect.jl 96.56% <100.00%> (+0.02%) :arrow_up:
src/simulations/sample.jl 100.00% <100.00%> (ø)
src/spaces/continuous.jl 92.34% <100.00%> (+0.04%) :arrow_up:
src/spaces/discrete.jl 98.87% <100.00%> (ø)
src/spaces/graph.jl 76.19% <100.00%> (ø)
src/spaces/grid_multi.jl 83.33% <100.00%> (ø)
... and 12 more

... and 12 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Datseris commented 10 months ago

@Tortar I've updated the rules of Agents.jl to ensure high quality of contributions.

  1. Can't push directly to master, must do PR.
  2. PRs must have one accepting review from someone other than the creator.

Things might get slower, but they are safer this way.