Closed Tortar closed 9 months ago
Merging #913 (98f113e) into main (ea3aa78) will decrease coverage by
11.41%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #913 +/- ##
===========================================
- Coverage 92.18% 80.77% -11.41%
===========================================
Files 33 45 +12
Lines 2277 2955 +678
===========================================
+ Hits 2099 2387 +288
- Misses 178 568 +390
Files | Coverage Δ | |
---|---|---|
src/core/space_interaction_API.jl | 93.23% <100.00%> (+0.05%) |
:arrow_up: |
... and 12 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Apparently this PR reduces code coverage by 10% :D nah that's clearly a mistake.
Yes this a bit absurd ahah I noted that already on previous commits, it seems like codecov sometimes randomly doesn't understand what are the files it shouldn't cover
You mentioned that you wanted to make this into a package. I think it is a great idea. You should, it is definitely helpful for a wide range of applications. But it isn't a priority either!
Working on it at the moment https://github.com/Tortar/IteratorSampling.jl but I'm thinking about some good tricks to make everything better and the package is still not good enough to release 0.1 so I need some more time to finish up the work since uni work is coming for me :D
This is faster, as some benchmark show, same code and metodology of #788
before
after
This is based on the relationship between an exponential rv and the logarithm of a uniform rv