JuliaDynamics / Agents.jl

Agent-based modeling framework in Julia
https://juliadynamics.github.io/Agents.jl/stable/
MIT License
717 stars 115 forks source link

Add quality code tests: Aqua.jl + method ambiguities test #921

Closed Tortar closed 8 months ago

Tortar commented 8 months ago

This resolved the 22 method ambiguities in Agents.jl. Notice that this resolved a bug with nearby_ids in a no space model which was ambiguous before, all other ambiguities are less important

codecov-commenter commented 8 months ago

Codecov Report

Merging #921 (c5521ad) into main (fa03585) will increase coverage by 0.00%. The diff coverage is 60.00%.

:exclamation: Current head c5521ad differs from pull request most recent head 7c14512. Consider uploading reports for the commit 7c14512 to get more accurate results

@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files          33       33           
  Lines        2274     2275    +1     
=======================================
+ Hits         2098     2099    +1     
  Misses        176      176           
Files Coverage Δ
src/spaces/discrete.jl 98.87% <100.00%> (ø)
src/spaces/grid_single.jl 100.00% <100.00%> (ø)
src/spaces/openstreetmap.jl 89.05% <100.00%> (+0.03%) :arrow_up:
src/core/space_interaction_API.jl 93.23% <0.00%> (ø)
src/spaces/nothing.jl 70.00% <0.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Tortar commented 8 months ago

I will also add Aqua.jl to the quality tests so expanding a bit the breadth of this PR :-)

Tortar commented 8 months ago