search

JuliaDynamics / Agents.jl

Agent-based modeling framework in Julia
https://juliadynamics.github.io/Agents.jl/stable/
MIT License
717 stars 115 forks source link

Implement abmtime for StandardABM #942

Closed Tortar closed 7 months ago

Tortar commented 7 months ago

Fix #941

This just changes the behaviour of the step data collection which now uses the correct time of the model

codecov-commenter commented 7 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3526b5c) 92.27% compared to head (a9d33c2) 92.18%.

Files Patch % Lines
src/simulations/collect.jl 90.47% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #942 +/- ## ========================================== - Coverage 92.27% 92.18% -0.09% ========================================== Files 33 33 Lines 2277 2291 +14 ========================================== + Hits 2101 2112 +11 - Misses 176 179 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tortar commented 7 months ago

should be good to go @Datseris, and it would be good to merge this one before #940 because I slightly changed internals, so that we can acknowledge those changes in #940 before merging

Datseris commented 7 months ago

Ah, I now realize that we don't mention this function in AgentBasedModel which describes the accessor API to ABMs.

Tortar commented 7 months ago

Also, I actually noticed too late that I slightly broke the abmexploration: when resetting the model, it returns to 0 step in data collection, which is correct, but doesn't play well with how data are plotted currently, will do a new PR fixing both of these issues eventually