search

JuliaDynamics / Agents.jl

Agent-based modeling framework in Julia
https://juliadynamics.github.io/Agents.jl/stable/
MIT License
717 stars 115 forks source link

Pin Makie to fix Agents 5.17 #954

Closed Tortar closed 6 months ago

Tortar commented 6 months ago

Fixes #948

Fixing the conflict has the effect to merge main into the branch, so it shouldn't be done

(this branch is at the last commit of 5.17.1)

Tortar commented 6 months ago

Releasing a new version from this branch should be enough, but I'm not totally sure about the correct procedure (see https://discourse.julialang.org/t/how-can-i-register-a-new-version-from-a-branch/108730)

Datseris commented 6 months ago

The problem is that current main has a buttload of changes, and this branch branches of current main. Releasing from this branch would not be what you want. Instead, you probably want to find the commit of the 5.17.1 branch from there, add this commit, push to origin, and then go to JuliaHub and tag a release from that branch.

Tortar commented 6 months ago

mmmh, this branch is already at the right commit though (last of 5.17.1), so I think it should be okay on that front

Datseris commented 6 months ago

right, yes, correct. okay, so then you can go ahead and tag a release from this branch? The PR is not necessary anyways.