search

JuliaDynamics / Agents.jl

Agent-based modeling framework in Julia
https://juliadynamics.github.io/Agents.jl/stable/
MIT License
712 stars 114 forks source link

Fix add_agent! with all default arguments #984

Closed Tortar closed 4 months ago

Tortar commented 4 months ago

Fixes #983

Tortar commented 4 months ago

Here we are again, tests are failing but with no real reason

Datseris commented 4 months ago

Is this really "without real reason"?

I see we get :

   UndefVarError: `#368#369` not defined

that is related with data collection.

Tortar commented 4 months ago

yes, it is, I don't have an explaination for the failures, but they are always the same

Tortar commented 4 months ago

just tested locally now, everything passed

Tortar commented 4 months ago

I will report an issue to Github itself linking to this PR as soon as we merge this to let they see that tests pass when the PR is merged