JuliaDynamics / Attractors.jl

Find attractors (and their basins) of dynamical systems. Perform global continuation. Study global stability (a.k.a. non-local, or resilience). Also tipping points functionality.
MIT License
32 stars 6 forks source link

Add `remacth!` function ; do some renames and doc polish #64

Closed Datseris closed 1 year ago

Datseris commented 1 year ago

Let me know if you disagree.

codecov-commenter commented 1 year ago

Codecov Report

Merging #64 (c853b47) into main (9453971) will increase coverage by 0.29%. The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   70.22%   70.51%   +0.29%     
==========================================
  Files          20       20              
  Lines        1105     1116      +11     
==========================================
+ Hits          776      787      +11     
  Misses        329      329              
Impacted Files Coverage Δ
src/continuation/aggregate_attractor_fractions.jl 94.73% <ø> (ø)
src/deprecated.jl 0.00% <ø> (ø)
src/continuation/continuation_recurrences.jl 88.88% <75.00%> (ø)
src/continuation/continuation_grouping.jl 97.72% <100.00%> (ø)
src/continuation/match_attractor_ids.jl 72.22% <100.00%> (+5.00%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

KalelR commented 1 year ago

All seems good to me, just the two small typos :)

awage commented 1 year ago

The new names are catchy. I don't see any problem since they are used in the context of continuation.

Good for me