Closed Datseris closed 3 years ago
@apbraun can you please remind me: these are all the improvements we wanted to do, right? I can merge away?
Yes these are all improvements. We spoke about adjusting the _autoprism
algorithm to the Theiler version and catch r0
< ε0
in the boxed_correlationsum
, I also spotted another bug in boxed_correlationsum
that I fixed, so from my part we're ready to go.
@apbraun please give me some help here. In our paper you said that "Bueno-Orovio and Pérez-García chose P=2 for D>2" where I assume that P stands for the Prism dimension. Here we don't do that, but we use I think an older approach by Theiler. Which one should we use in the end...?
@apbraun let's do all necessary improvements in this PR.