search

JuliaDynamics / ChaosTools.jl

Tools for the exploration of chaos and nonlinear dynamics
https://juliadynamics.github.io/DynamicalSystemsDocs.jl/chaostools/stable/
MIT License
189 stars 36 forks source link

Rewritten rescale in lyapunovs.jl #214

Closed SudoMishra closed 1 year ago

SudoMishra commented 3 years ago

I rewrote the rescale function in lyapunov.jl with get_state and set_state functions as you had mentioned. In the current form of the rescale function, we no longer need multiple rescale functions as that can be handled by the multiple dispatches of get_state and set_state for different scenarios.

I'm unsure about the type of declarations that would go with the new rescale function but I think as now it handles both vector and matrix scenarios, the type declaration might not be needed.

I'm new to Julia and git. This is my first PR. I'm quite interested in contributing more to this package. Thank you.

Datseris commented 3 years ago

Huh, why was this PR closed? It was going good with only a small amount of tweaking needed.

SudoMishra commented 3 years ago

Oh sorry, I was trying to make a PR on my forked repo and I think I messed up and closed this PR. I'll reopen it.

Datseris commented 3 years ago

@SudoMishra test fail so something is going wrong with the way you rescale, can you have a closer look?