search

JuliaDynamics / ChaosTools.jl

Tools for the exploration of chaos and nonlinear dynamics
https://juliadynamics.github.io/DynamicalSystemsDocs.jl/chaostools/stable/
MIT License
187 stars 35 forks source link

Remove some duplicate code from bSTAB implementation #246

Closed awage closed 2 years ago

awage commented 2 years ago

I was trying to understand the code more in detail and I found a way to reduce the codebase without affecting the performances.

Have a look a the change. If you think it is not worth it or too risky changing something that works you can close this PR.

awage commented 2 years ago

Test fails here but it passed on my computer. I will fix it.

awage commented 2 years ago

It seems that the test fails sometimes. Even on the master branch. Is there a way to set the random generator seed? Another way is to use more samples but tests are getting very long. I ran the test again and it has succeeded the second time.

Datseris commented 2 years ago

It seems that the test fails sometimes.

Which tests? Yes, there is a way to set random seeds.

awage commented 2 years ago

Sometime Basin Fractions Clustering Pendulum fails and also Correlation Dim.

For Basin Fractionsthe results are almost within the bounds but due to the sample it sometimes steps out the interval.

Datseris commented 2 years ago

I'll have a look in the other PR.