JuliaDynamics / ChaosTools.jl

Tools for the exploration of chaos and nonlinear dynamics
https://juliadynamics.github.io/DynamicalSystemsDocs.jl/chaostools/stable/
MIT License
186 stars 35 forks source link

Use set_state! in lyapunov rescale! #289

Closed xlxs4 closed 1 year ago

xlxs4 commented 1 year ago

Closes #213. From the issue:

we can do some optimization so that we have a dummy preinitialized r that we carry around and modify its value in place so that we don't create a new r all the time

Open to any pointers.


Tests pass locally:

image

Datseris commented 1 year ago

Ah. also, there is an ongoing PR that tries to fix the same thing but turned out to be more complicated: https://github.com/JuliaDynamics/ChaosTools.jl/pull/214

Datseris commented 1 year ago

I'll have a look but I can't promise when (same thing with the #214 ) , because I have many projects going on :( But the code here looks like a simpler change so I think I'll get to this quickly enough!