search

JuliaDynamics / ChaosTools.jl

Tools for the exploration of chaos and nonlinear dynamics
https://juliadynamics.github.io/DynamicalSystemsDocs.jl/chaostools/stable/
MIT License
186 stars 35 forks source link

Correct assignment of Q matrix for lyapunovspectrum with k < d #303

Closed Datseris closed 1 year ago

Datseris commented 1 year ago

Wow. All these years. 5 years? the code for Lyapunov exponents was "wrong". Haha. It worked, but it was not coded properly. So I was just lucky that it worked. Now in the v3 re-write, the same code doesn't work.

This PR puts in a proper code that correctly respects the API and maps a higher size Q matrix to the deviations matrix.

Closes #302.

codecov-commenter commented 1 year ago

Codecov Report

Merging #303 (e688dde) into main (e665427) will increase coverage by 0.63%. The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   47.59%   48.23%   +0.63%     
==========================================
  Files          22       22              
  Lines         893      904      +11     
==========================================
+ Hits          425      436      +11     
  Misses        468      468
Impacted Files Coverage Δ
src/chaosdetection/lyapunovs/lyapunovspectrum.jl 87.23% <92.30%> (+3.90%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more