JuliaDynamics / ChaosTools.jl

Tools for the exploration of chaos and nonlinear dynamics
https://juliadynamics.github.io/DynamicalSystemsDocs.jl/chaostools/stable/
MIT License
186 stars 35 forks source link

update `predictability` to DynamicalSystems.jl v3.0. #312

Closed rusandris closed 10 months ago

rusandris commented 11 months ago

Hi everyone! I've started to update predictability to DynamicalSystems.jl v3.0, this being the first batch of changes. It seems to be working, all tests pass. There are some other TODOs here in there in the comments, so further improvements can be made regarding code readibility/design etc. Let me know what you think.

Datseris commented 11 months ago

also increment patch version in project toml

codecov-commenter commented 11 months ago

Codecov Report

Merging #312 (3a21c88) into main (da6a84e) will increase coverage by 0.05%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   48.45%   48.50%   +0.05%     
==========================================
  Files          22       22              
  Lines         904      903       -1     
==========================================
  Hits          438      438              
+ Misses        466      465       -1     
Files Changed Coverage Δ
src/chaosdetection/partially_predictable.jl 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Datseris commented 11 months ago

oh yerah you also have to actually enable the test file: https://github.com/JuliaDynamics/ChaosTools.jl/blob/main/test/runtests.jl#L25

rusandris commented 10 months ago

Hi! It seems like it's close to completion with your additional bugfixes. I've also added a reinit! at the first line so we don't run into problems when predictability needs to run multiple times (it is a mutating function). There are also some little things here and there, let me know if it's okay.

rusandris commented 10 months ago

Also enabled the tests in test/run_tests.jl. Also I noticed that I messed up the commit message. Is it editable easily afterwards?

Datseris commented 10 months ago

Don't worry about the commit message. Can you please increment the patch number (third number) in the Project.toml file, as this is a bugfix?