Closed JonasKoziorek closed 4 months ago
I renamed it as VectorWithEpsRadius since it's used with SVectors.
Should the changelog include info about both PRs? I will make another PR this week adding the Davidchack-Lai algorithm. It will internally also make use of VectorWithEpsRadius. Perhaps all three could be released together.
we can add the changelog in your 3rd PR, it's fine.
I noticed that while using periodicorbits algorithm with parameter roundtol that is high (eg. 8 ), it detects many duplicate UPOs. MVE:
Output:
My proposed change solves this:
Output:
I have implemented
FP
as a binary tree. This way, new fixed points are inserted intoFP
only if they arespacetol
away from the remaining fixed points inFP
. Thus duplicates are avoided for a good choice ofspacetol
.Additionally, binary tree removes the need for linear search through
FP
even though this doesn't seem to be a bottleneck.Let me know if there is something to fix. This is my first PR :).