search

JuliaDynamics / ChaosTools.jl

Tools for the exploration of chaos and nonlinear dynamics
https://juliadynamics.github.io/DynamicalSystemsDocs.jl/chaostools/stable/
MIT License
188 stars 36 forks source link

New algorithm for detection of UPOs #328

Closed JonasKoziorek closed 6 months ago

JonasKoziorek commented 6 months ago

Hi!

I have added Davidchack-Lai algorithm for detection of unstable periodic orbits: https://journals.aps.org/pre/abstract/10.1103/PhysRevE.60.6172 https://www.sciencedirect.com/science/article/pii/S0375960101004637

I have included docstring and tests. I have also wrote examples for documentation, however I don't know how to create the documentation website locally, so I haven't seen the output. When I run /docs/make.jl it results in an error even without my additions.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 92.92035% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 61.10%. Comparing base (928bdb0) to head (4a19099). Report is 6 commits behind head on main.

Files Patch % Lines
src/periodicity/davidchacklai.jl 95.34% 4 Missing :warning:
src/periodicity/lambdamatrix.jl 84.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #328 +/- ## ========================================== + Coverage 54.86% 61.10% +6.23% ========================================== Files 22 25 +3 Lines 904 1036 +132 ========================================== + Hits 496 633 +137 + Misses 408 403 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Datseris commented 6 months ago

I'll fix the docs in this PR and then review...

Datseris commented 6 months ago

I am merging this in, we don't have a changelog entry yet, but you mentioned you will do this in a different PR!