JuliaDynamics / ComplexityMeasures.jl

Estimators for probabilities, entropies, and other complexity measures derived from data in the context of nonlinear dynamics and complex systems
MIT License
54 stars 12 forks source link

Adjust `GaussianCDFEncoding` and related stuff for new encoding API #199

Closed kahaaga closed 1 year ago

kahaaga commented 1 year ago

I have now adjusted the codebase so that GaussianCDFEncoding obeys the encoding API. This addresses another point in #190.

The alternative to this entire approach would be to extend the encoding API to be defined for vector-valued inputs, which I don't want to do, because it complicates things unnecessarily. I think the approach here is more elegant anyways, because it is now trivial to user some other encoding by just specifying the encoding keyword to Dispersion (again, this is not in the public API atm).

Other stuff:

@datseris I will merge this immediately when CI is done, so I can finish up #126 (which depends on this stuff). If you have any comments, just leave them here (or open issues if necessary), and I will address them while working on #126.

Datseris commented 1 year ago

it's okay, I have planned that we have to do a full review of the entire code base before publish anyways. I just haven't told you about this plan yet xD xD xD

kahaaga commented 1 year ago

I figured as much 🤖