search

JuliaDynamics / ComplexityMeasures.jl

Estimators for probabilities, entropies, and other complexity measures derived from data in the context of nonlinear dynamics and complex systems
MIT License
53 stars 12 forks source link

Fix `RectangularBinEncoder` error message when dimensions of binning and input data do not match #248

Closed kahaaga closed 1 year ago

kahaaga commented 1 year ago

The title is self-explanatory. I also added a test that catches the error.

Datseris commented 1 year ago

tests fail however

kahaaga commented 1 year ago

tests fail however

This PR affects nothing but the error message thrown when dimensions are incompatible. The tests failing are related to the transfer operator (which I though we fixed), which should be unrelated to this. I'll dive a bit deeper tomorrow.

Datseris commented 1 year ago

Tests on main pass, so the error must come from this PR changes https://github.com/JuliaDynamics/ComplexityMeasures.jl/actions/runs/3919167386

kahaaga commented 1 year ago

The tests also fail on main now after the latest commit, which only changed the Readme.md file. I'm not sure why the tests didn't fail on main before. This will require some deeper digging, which I'll do as part of the CausalityTools review that we're currently working on.

Datseris commented 1 year ago

bump here? probably after rebase to main should be good.

kahaaga commented 1 year ago

bump here? probably after rebase to main should be good.

Yes, tests pass now.