Closed kahaaga closed 1 year ago
Merging #257 (1a14d38) into main (72f457b) will increase coverage by
0.07%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 81.06% 81.14% +0.07%
==========================================
Files 49 49
Lines 1236 1241 +5
==========================================
+ Hits 1002 1007 +5
Misses 234 234
Impacted Files | Coverage Δ | |
---|---|---|
src/entropies_estimators/nearest_neighbors/Gao.jl | 100.00% <100.00%> (ø) |
|
...rc/entropies_estimators/nearest_neighbors/Goria.jl | 100.00% <100.00%> (ø) |
|
...estimators/nearest_neighbors/KozachenkoLeonenko.jl | 100.00% <100.00%> (ø) |
|
.../entropies_estimators/nearest_neighbors/Kraskov.jl | 100.00% <100.00%> (ø) |
|
src/entropies_estimators/nearest_neighbors/Lord.jl | 100.00% <100.00%> (ø) |
|
src/entropies_estimators/nearest_neighbors/Zhu.jl | 100.00% <100.00%> (ø) |
|
...entropies_estimators/nearest_neighbors/ZhuSingh.jl | 100.00% <100.00%> (ø) |
|
...ies_estimators/order_statistics/AlizadehArghami.jl | 100.00% <100.00%> (ø) |
|
...rc/entropies_estimators/order_statistics/Correa.jl | 100.00% <100.00%> (ø) |
|
.../entropies_estimators/order_statistics/Ebrahimi.jl | 100.00% <100.00%> (ø) |
|
... and 2 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
As long as convert_logunit
isn't documented, it's not part of the public API, so we can adjust code internally later if necessary.
For now, this PR fixes all upstreams bugs. I am therefore merging as soon as tests pass.
In the future note that bugfixes increment the patch version (third number), not the minor verison (second number)
Summary:
convert_logunit
that converts between numbers computed with different logarithm bases. This method is exported as a convenience function, and is tested, to ensure the errors in #256 can never occur. However, it is not documented yet. We can decide later if it should be.convert_logunit
for all differential entropy estimator code and tests.