search

JuliaDynamics / ComplexityMeasures.jl

Estimators for probabilities, entropies, and other complexity measures derived from data in the context of nonlinear dynamics and complex systems
MIT License
56 stars 14 forks source link

Allow using `entropy` without an estimator. #283

Closed Datseris closed 1 year ago

Datseris commented 1 year ago

I see:

┌ Warning: `entropy(e::EntropyDefinition, est::ProbabilitiesEstimator, x)` is deprecated.
│ From 3.0 onwards, use `information(PlugIn(measure = e), est, x)` instead.
└ @ ComplexityMeasures C:\Users\gd419\.julia\dev\ComplexityMeasures\src\deprecations.jl:93

which I don't like :D Can't we allow people to just use the entropy definition in which case it dispatches the the plug in estimator?

kahaaga commented 1 year ago

Sure, if we add a note in the docstring, that should be fine.

kahaaga commented 1 year ago

Ah, you mean using the entropy function instead of the information function? Yes, we can just silently allow it

Datseris commented 1 year ago

Sure, if we add a note in the docstring, that should be fine.

We already had this note in 2.8; we said that there is no reason to use PlugIn as the entropy definitions can be used directly.