propagate isless in ordinal encoding

JuliaDynamics / ComplexityMeasures.jl

Estimators for probabilities, entropies, and other complexity measures derived from data in the context of nonlinear dynamics and complex systems

MIT License

48 stars 11 forks source link

propagate isless in ordinal encoding #415

Open Datseris opened 3 weeks ago

Datseris commented 3 weeks ago

Closes #378

I'm taken aback that we didn't fix this before the paper...

kahaaga commented 3 weeks ago

I'm taken aback that we didn't fix this before the paper...

Better now than never, though

kahaaga commented 3 weeks ago

For the failing tests: I guess the result of unique(res) must be sorted?

Datseris commented 3 weeks ago

holy shit what happened I see countless failures throughout the library now :D

Datseris commented 3 weeks ago

i also see countless calls to deprecated functions in the test suite. Oh man, i think I have to invest some time in the tests...

kahaaga commented 3 weeks ago

i also see countless calls to deprecated functions in the test suite. Oh man, i think I have to invest some time in the tests...

It's because we also need to test the deprecations, no? We're going to be at v3 for some time, and new users will likely never use deprecated syntax anyways, so I'm fine with just removing all the deprecations fully and releasing a new minor version stating that.

kahaaga commented 3 weeks ago

The tests for ordinal patterns fail now because they were designed for cases with no random shuffling in the case of ties. Just need to pass on the correct function to restore their behavior and add a few more tests for the random case, as planned