Refactor gMAM - Githubissues

JuliaDynamics / CriticalTransitions.jl

A Julia package for critical transitions in dynamical systems with time-dependent forcing

https://juliadynamics.github.io/CriticalTransitions.jl/dev/

MIT License

26 stars 3 forks source link

Refactor gMAM #25

Closed oameye closed 6 months ago

oameye commented 7 months ago

@reykboerner What is the reason that we have to re-interpolate the path after every optimization path? I guess it ensures continuity of the path? It would be nice if we could enforce this within the Optimizer of Optim.jl. Not sure if it possible tho.

reykboerner commented 6 months ago

Hi @oameye, are there any changes here that change what geometric_min_action_method does or are they all just cosmetic in terms of how the code is written? It's a bit difficult to tell from the PR title and by scrolling through the changes.

oameye commented 6 months ago

All the changes should be cosmetic. I just refactored and reformatted the code. The main changes are:

Refactored the interpolation step into its own function
Make the two methods dependent on each other, that way we don't have redundant code.
Ran a JuliaFormatter.jl with the SciML style.

reykboerner commented 6 months ago

Great, thanks for the additional description! Merging this now.