JuliaDynamics / CriticalTransitions.jl

A Julia package for critical transitions in dynamical systems with time-dependent forcing
https://juliadynamics.github.io/CriticalTransitions.jl/dev/
MIT License
18 stars 2 forks source link

Stochsystem overhaul #76

Open oameye opened 2 months ago

oameye commented 2 months ago

Work on #75, #42 and #22

reykboerner commented 2 months ago

I've taken a quick look at this and have three comments:

oameye commented 2 months ago

We should also import the step! and set_state! functions used in DynamicalSystemsBase and then rewrite the callbacks in e.g. transition in terms of these functions. This seems to be faster than callbacks.

The documentation of DynamicalSystems.jl says that recommend using ODEProblem when using callbacks. image

oameye commented 2 months ago

We should only merge once the CI, Dowgrade and docs are working. Will take a look tonight :)

reykboerner commented 2 months ago

The transition function throws an error in the tests:

ERROR: cannot assign a value to imported variable CriticalTransitions.trajectory from module Main

Can check later what the issue is. Also, trajectory seems to be a lot slower than simulate. Do you know why @oameye ?

oameye commented 2 months ago

We need to update the docs.

oameye commented 2 months ago

dev, examples and ext have still to be updated

oameye commented 1 month ago
oameye commented 1 week ago

DynamicalSystems allows the parameters to be of the type that the ODEProblem allows.