Open oameye opened 2 months ago
I've taken a quick look at this and have three comments:
CoupledSDEs
now has one parameter field p
for both functions f
and g
, but I still think there should be a constructor function that lets you pass individual parameter fields pf
and pg
as input arguments (because otherwise it will be difficult to combine existing CoupledODEs
drift functions with different noise functions).step!
and set_state!
functions used in DynamicalSystemsBase and then rewrite the callbacks in e.g. transition
in terms of these functions. This seems to be faster than callbacks.CoupledSDEs
to match the nomenclature of CoupledODEs
, but our package focuses more on noise- and rate-induced transitions, so should we still keep an alias like StochSystem
or StochasticSystem
?We should also import the
step!
andset_state!
functions used in DynamicalSystemsBase and then rewrite the callbacks in e.g. transition in terms of these functions. This seems to be faster than callbacks.
The documentation of DynamicalSystems.jl says that recommend using ODEProblem when using callbacks.
We should only merge once the CI, Dowgrade and docs are working. Will take a look tonight :)
The transition
function throws an error in the tests:
ERROR: cannot assign a value to imported variable CriticalTransitions.trajectory from module Main
Can check later what the issue is. Also, trajectory
seems to be a lot slower than simulate
. Do you know why @oameye ?
We need to update the docs.
dev, examples and ext have still to be updated
DynamicalSystems allows the parameters to be of the type that the ODEProblem allows.
Work on #75, #42 and #22