Open Datseris opened 3 years ago
Unfortunately PECUZAL is the most brittle, seems to have the most failures when running on different PC.
Hey @Datseris , I have also encountered an issue with the Uzal-algorithm, which also effects PECUZAL. I will take care of all of this once I'm back from vacation, so expect me to fix this by mid of August.
Hi Hauke, sounds cool, no stress!
In #103 I also revised the test for mdop
& garcia_almeida
, which is why I think you can close this one here. However: I did dive deeper into the code. Especially garcia_almeida
used to give some (physically) wired results as far as I can remember.
Let's keep this open until #94 is resolved as well (i.e., all tested timeseries are loaded from csv files).
We have established the validity of our unified embedding methods because we even wrote a paper utilizing them in detail and comparing them with each other. There isn't any doubt that they work. However, the way we have written our tests is brittle, because (due to chaos) running the test on different machines may make them fail. For example while working on PR #93 I've seen things like:
and even
(i.e. a lower-dimensional embedding is produced sometimes)
We need to re-write tests in a different manner. First increase the error margins, but also come up with tests that are not so brittle and depend sensitively on the chaotic nature of trajectories. Furthermore, this issue needs to be solved in conjuction with #94 , which would make trajectories no longer simulated but rather available as
.csv
files from the get go.@hkraemer I'm also cc'ing you for reference.