search

JuliaDynamics / DiscreteEvents.jl

Discrete event generation and simulation in Julia
MIT License
56 stars 10 forks source link

Remove DataFrames dependency. #11

Closed non-Jedi closed 4 years ago

non-Jedi commented 4 years ago

DataFrames is a heavyweight package. Implementing a simple Tables.jl-compatible type allows users to still get a DataFrame by calling DataFrame(logger) without carrying the dependency on DataFrames itself.

codecov[bot] commented 4 years ago

Codecov Report

Merging #11 into master will decrease coverage by 2.55%. The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage     100%   97.44%   -2.56%     
==========================================
  Files           7        7              
  Lines         334      352      +18     
==========================================
+ Hits          334      343       +9     
- Misses          0        9       +9
Impacted Files Coverage Δ
src/Simulate.jl 100% <ø> (ø) :arrow_up:
src/logger.jl 79.06% <59.09%> (-20.94%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 530b4ed...02f38c9. Read the comment docs.

pbayer commented 4 years ago

my idea was to remove logging.jl altogether since in all my experiments/examples I didn't use it but realized logging otherwise.

Is it worth to keep or rewrite logging.jl? What do you think?

non-Jedi commented 4 years ago

I think getting rid of the logging portion is a grand idea. Would also solve #12.

pbayer commented 4 years ago

So I merge now and then we remove the logging.jl in the next step to solve #12 .