Clock sample rate not calculated appropriately

JuliaDynamics / DiscreteEvents.jl

Discrete event generation and simulation in Julia

MIT License

56 stars 10 forks source link

Closed pbayer closed 4 years ago

pbayer commented 4 years ago

As commented there we need a better heuristic to calculate the sample rate in _register!(c::Clock, cond::DiscreteCond).

pbayer commented 4 years ago

Now the heuristic is to

set the default sample rate to 0.01
if the user sets the sample to 0 and then creates a conditional event or a sampling function with periodic!, the sample rate is calculated as 1/100 the scale of the interevent time so far.

pbayer commented 4 years ago

The original example given by @itsdfish in Execute process as soon as wait condition is satisfied #1 on ‘DiscreteEventsCompanion.jl‘ now runs correctly.

pbayer commented 4 years ago

The new heuristic seems to work so far. Therefore I close this for now.