search

JuliaDynamics / DiscreteEvents.jl

Discrete event generation and simulation in Julia
MIT License
57 stars 10 forks source link

Aqua.jl found method ambiguity #55

Open hdavid16 opened 1 year ago

hdavid16 commented 1 year ago

https://github.com/JuliaDynamics/DiscreteEvents.jl/blob/4a9fab45a9af19c7d940a48714afb707b2e7598d/src/types.jl#L139-L140

A user could use Prc(::Function, ::Function, arg...; kw...), making the outcome ambiguous. We should probably define a type for the Process ID

hdavid16 commented 1 year ago

@pbayer, How do we want to handle this? Should we just constrain process ids to be Union{Number, Symbol, String} or do you want to define a struct? Something like...

abstract type AbstractID end
struct ProcessID{T} <: AbstractID
    id::T
end