JET.jl found errors - Githubissues

JET found some issues with the code: Need to address 6th, 10th, and 12th items in following list

[x] first set: Shouldn't be an issue because _cid isn't called on a ClockChannel ever because if there is a ClockChannel the c.id == 1. Instead, it is called on ActiveClock, which is defined. Same for _register.

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:129 event!(𝐶 , ex, t)
│┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:68 DiscreteEvents.:(var"#event!#11")(clk.id, false, #self#, clk, ex, t)
││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:72 DiscreteEvents._cid(clk, cid, spawn)
│││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:230 DiscreteEvents._cid(c.ac[], cid, spawn)
││││ no matching method found `_cid(::DiscreteEvents.ClockChannel, ::Int64, ::Bool)`: DiscreteEvents._cid(((c::DiscreteEvents.Clock{Vector{DiscreteEvents.ClockChannel}}).ac::Vector{DiscreteEvents.ClockChannel})[]::DiscreteEvents.ClockChannel, cid::Int64, spawn::Bool)
│││└─────────────────────────────────────────────────────────────
││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:72 DiscreteEvents._assign(clk, DiscreteEvents.DiscreteEvent(ex, t, DiscreteEvents.nothing, 1), DiscreteEvents._cid(clk, cid, spawn))
│││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:285 DiscreteEvents._register!(c, ev)
││││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:294 goto %21 if not DiscreteEvents.any(#30, DiscreteEvents.values(c.sc.events)) 
│││││ non-boolean `Missing` found in boolean context (1/2 union split): goto %21 if not DiscreteEvents.any(#30::DiscreteEvents.var"#30#31", DiscreteEvents.values(((c::DiscreteEvents.Clock{Vector{DiscreteEvents.ClockChannel}}).sc::DiscreteEvents.Schedule).events::DataStructures.PriorityQueue{DiscreteEvents.DiscreteEvent, Float64})::Base.ValueIterator)::Union{Missing, Bool}
││││└─────────────────────────────────────────────────────────────
│││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:287 DiscreteEvents._register(c, ev, id)
││││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:326 DiscreteEvents._register(c.ac[], ev, id)
│││││ no matching method found `_register(::DiscreteEvents.ClockChannel, ::DiscreteEvents.DiscreteEvent{Expr, Nothing}, ::Int64)`: DiscreteEvents._register(((c::DiscreteEvents.Clock{Vector{DiscreteEvents.ClockChannel}}).ac::Vector{DiscreteEvents.ClockChannel})[]::DiscreteEvents.ClockChannel, ev::DiscreteEvents.DiscreteEvent{Expr, Nothing}, id::Int64)
││││└─────────────────────────────────────────────────────────────

[x] second set: same as first set, shouldn't be an issue.

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:129 Core.kwfunc(event!)(merge(Base.NamedTuple(), kw), event!, 𝐶 , ex, t)
│┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:68 DiscreteEvents.:(var"#event!#11")(cid, spawn, _3, clk, ex, t)
││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:72 DiscreteEvents._cid(clk, cid, spawn)
│││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:224 DiscreteEvents._spawnid(c)
││││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:216 DiscreteEvents._spawnid(c.ac[])
│││││ no matching method found `_spawnid(::DiscreteEvents.ClockChannel)`: DiscreteEvents._spawnid(((c::DiscreteEvents.Clock{Vector{DiscreteEvents.ClockChannel}}).ac::Vector{DiscreteEvents.ClockChannel})[]::DiscreteEvents.ClockChannel)
││││└─────────────────────────────────────────────────────────────

[x] third set: same as first set, shouldn't be an issue.

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:204 periodic!(𝐶 , ex, Δt)
│┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:197 DiscreteEvents.:(var"#periodic!#27")(clk.id, false, #self#, clk, ex, Δt)       
││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:202 DiscreteEvents._assign(clk, DiscreteEvents.Sample(ex), DiscreteEvents._cid(clk, cid, spawn))
│││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:287 DiscreteEvents._register(c, ev, id)
││││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:326 DiscreteEvents._register(c.ac[], ev, id)
│││││ no matching method found `_register(::DiscreteEvents.ClockChannel, ::DiscreteEvents.Sample{Expr}, ::Int64)`: DiscreteEvents._register(((c::DiscreteEvents.Clock{Vector{DiscreteEvents.ClockChannel}}).ac::Vector{DiscreteEvents.ClockChannel})[]::DiscreteEvents.ClockChannel, ev::DiscreteEvents.Sample{Expr}, id::Int64)
││││└─────────────────────────────────────────────────────────────

[x] fourth set: shouldn't be an issue because values(c.sc.events) shouldn't return missing

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\schedule.jl:294 goto %21 if not DiscreteEvents.any(#30, DiscreteEvents.values(c.sc.events))     
│ non-boolean `Missing` found in boolean context (1/2 union split): goto %21 if not DiscreteEvents.any(#30::DiscreteEvents.var"#30#31", DiscreteEvents.values(((c::DiscreteEvents.Clock).sc::DiscreteEvents.Schedule).events::DataStructures.PriorityQueue{DiscreteEvents.DiscreteEvent, Float64})::Base.ValueIterator)::Union{Missing, Bool}
└─────────────────────────────────────────────────────────────

[x] fifth set: c.tn and c.tev shouldn't ever be missing

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\clock.jl:294 goto %27 if not DiscreteEvents.any(#47, tuple(c.tn, c.tev))
│ non-boolean `Missing` found in boolean context (1/2 union split): goto %27 if not DiscreteEvents.any(#47::DiscreteEvents.var"#47#48", tuple((c::DiscreteEvents.Clock).tn::Float64, (c::DiscreteEvents.Clock).tev::Float64)::Tuple{Float64, Float64})::Union{Missing, Bool}
└──────────────────────────────────────────────────────────

[x] sixth set: assign function is not defined...

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\clock.jl:330 DiscreteEvents.assign(getfield(#self#, :clk), token.ev, token.id)
│ `DiscreteEvents.assign` is not defined
└──────────────────────────────────────────────────────────

[x] seventh set: Prc.clk shouldn't be nothing here since it is set with _clock

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:33 DiscreteEvents._register!(p.clk, p)
│ no matching method found `_register!(::Nothing, ::DiscreteEvents.Prc)` (1/2 union split): DiscreteEvents._register!((p::DiscreteEvents.Prc).clk::Union{Nothing, DiscreteEvents.AbstractClock}, p::DiscreteEvents.Prc)
└───────────────────────────────────────────────────────────

[x] eighth set: same as seventh set

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:45 p.clk.processes
│┌ @ Base.jl:38 Base.getfield(x, f)
││ type Nothing has no field processes
│└──────────────
┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:45 p.clk.processes = DiscreteEvents.delete!(p.clk.processes, p.id)
│┌ @ Base.jl:39 Base.fieldtype(Base.typeof(x), f)
││ type Nothing has no field processes
│└──────────────

[x] ninth set: I don't think this should be an issue either since p.task is set with p.task = @task _loop(p, cycles) in startit()

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:87 #self#(c, p, DiscreteEvents.Inf)
│┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:87 DiscreteEvents.:(var"#process!#64")(c.id, false, #self#, c, p, cycles)
││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:90 t = DiscreteEvents._startup!(c, p, cycles, cid, spawn)
│││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:60 startit()
││││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:53 DiscreteEvents.yield(getfield(#self#, :p).task)
│││││ no matching method found `yield(::Nothing)` (1/2 union split): DiscreteEvents.yield((getfield(#self#::DiscreteEvents.var"#startit#60"{DiscreteEvents.Prc, Float64}, :p)::DiscreteEvents.Prc).task::Union{Nothing, Task})
││││└───────────────────────────────────────────────────────────

[x] tenth set: not sure on this one, but has to do with Base.schedule...

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:157 Core.kwfunc(DiscreteEvents.schedule)(NamedTuple{(:error,)}(tuple(true)), DiscreteEvents.schedule, p.task, PrcException(ev, value))
│ no matching method found `(::Base.var"#schedule##kw")(::NamedTuple{(:error,), Tuple{Bool}}, ::typeof(schedule), ::Nothing, ::DiscreteEvents.PrcException)` (1/2 union split): Core.kwfunc(DiscreteEvents.schedule)::Base.var"#schedule##kw"(NamedTuple{(:error,)}(tuple(true)::Tuple{Bool})::NamedTuple{(:error,), Tuple{Bool}}, DiscreteEvents.schedule, (p::DiscreteEvents.Prc).task::Union{Nothing, Task}, PrcException(ev::Any, value::Any)::DiscreteEvents.PrcException)
└────────────────────────────────────────────────────────────
┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:162 #self#(p, DiscreteEvents.nothing)
│┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:162 interrupt!(p, DiscreteEvents.Stop(), value)
││┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\process.jl:157 Core.kwfunc(DiscreteEvents.schedule)(NamedTuple{(:error,)}(tuple(true)), DiscreteEvents.schedule, p.task, PrcException(ev, value))
│││ no matching method found `(::Base.var"#schedule##kw")(::NamedTuple{(:error,), Tuple{Bool}}, ::typeof(schedule), ::Nothing, ::DiscreteEvents.PrcException{DiscreteEvents.Stop, Nothing})` (1/2 union split): Core.kwfunc(DiscreteEvents.schedule)::Base.var"#schedule##kw"(NamedTuple{(:error,)}(tuple(true)::Tuple{Bool})::NamedTuple{(:error,), Tuple{Bool}}, DiscreteEvents.schedule, (p::DiscreteEvents.Prc).task::Union{Nothing, Task}, PrcException(ev::DiscreteEvents.Stop, value::Nothing)::DiscreteEvents.PrcException{DiscreteEvents.Stop, Nothing})
││└────────────────────────────────────────────────────────────

[x] eleventh set: I don't think there is any problem here....

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\threads.jl:57 DiscreteEvents.error(string("transition q=", q, ", σ=", σ, " not implemented"))   
│┌ @ error.jl:35 error(::String)
││ may throw: Base.throw(Base.ErrorException(s::String)::ErrorException)
│└───────────────

[x] twelfth set: Needs to be fixed. I think should be length(master.ac)

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\threads.jl:133 DiscreteEvents.clk.ac
│ `DiscreteEvents.clk` is not defined
└────────────────────────────────────────────────────────────

[x] thirtheenth set: same as 4th set

┌ @ C:\Users\HD\.julia\dev\DiscreteEvents\src\threads.jl:162 goto %57 if not DiscreteEvents.any(#77, DiscreteEvents.values(master.sc.events)) 
│ non-boolean `Missing` found in boolean context (1/2 union split): goto %57 if not DiscreteEvents.any(#77::DiscreteEvents.var"#77#78", DiscreteEvents.values(((master::DiscreteEvents.Clock).sc::DiscreteEvents.Schedule).events::DataStructures.PriorityQueue{DiscreteEvents.DiscreteEvent, Float64})::Base.ValueIterator)::Union{Missing, Bool}
└────────────────────────────────────────────────────────────

JuliaDynamics / DiscreteEvents.jl

JET.jl found errors #56