I fixed the Makie.Layout error I raised in #237 by removing that qualifier from the deactivate_interaction! call.
Other changes that can be ommitted upon review
I removed some display(figure) calls because they seemed unnecessary and aren't shared by the other interactive plotting scripts.
I preallocated the Vector{Point2f} in the first minimal_normalized_od method because the length is known at compile time (the other method has conditional push so left it as is)
Finally, I added a testset and a test for calling this plotting function. Not sure if you guys don't use a Test.jl based CI for a reason or was just never implemented. The test fails with an error with the prior code but passes now.
I fixed the
Makie.Layout
error I raised in #237 by removing that qualifier from thedeactivate_interaction!
call.Other changes that can be ommitted upon review
display(figure)
calls because they seemed unnecessary and aren't shared by the other interactive plotting scripts.Vector{Point2f}
in the firstminimal_normalized_od
method because the length is known at compile time (the other method has conditional push so left it as is)Test.jl
based CI for a reason or was just never implemented. The test fails with an error with the prior code but passes now.