search

JuliaDynamics / DynamicalSystemsBase.jl

Definition of dynamical systems and integrators for DynamicalSystems.jl
Other
56 stars 29 forks source link

typo in docstring #174

Closed awage closed 1 year ago

Datseris commented 1 year ago

While we are on this: @assert should not be used to check for errors.

We need to replace all @assert x "mplah mplah" with x || error("mplah mplah")

awage commented 1 year ago

Poincaré map test fails at some point. Maybe it's the solver?

awage commented 1 year ago

While we are on this: @assert should not be used to check for errors.

We need to replace all @assert x "mplah mplah" with x || error("mplah mplah")

Ok, I'll change this file.

Datseris commented 1 year ago

Yeah the Poincare tests now fail because the test suite moved to the newly released Julia 1.9. Our code shouldn't have been affected, but I maybe DifferentialEquations.jl were affected. I am not sure, cc @ChrisRackauckas do you know of any numerical instabilities that crept in ODE solving? We have lost accuracy in the Poincare map functionality. (I haven't taken a detailed look yet, I am not certain that the problem comes from the ODE solving; another candidate is Roots.jl).

ChrisRackauckas commented 1 year ago

We have a PSOS regression test from you that we keep around:

https://github.com/SciML/OrdinaryDiffEq.jl/blob/fc8721942d3eda4d98a27015a74f9e32684d8857/test/regression/psos_and_energy_conservation.jl

It has to pass for our tests to pass.