search

JuliaDynamics / DynamicalSystemsBase.jl

Definition of dynamical systems and integrators for DynamicalSystems.jl
Other
56 stars 29 forks source link

add missing package loading #180

Closed rusandris closed 1 year ago

rusandris commented 1 year ago

I've added the missing LinearAlgebra loading. See Issue 179 for details.

Datseris commented 1 year ago

can you please add a test that catches the bug as well please?

it's as simple as adding another line here https://github.com/JuliaDynamics/DynamicalSystemsBase.jl/blob/main/test/poincare.jl#L96 that computes the same with plane :: Vector

Datseris commented 1 year ago

and also please bump patch version in Project.toml

rusandris commented 1 year ago

Great! You can merge and close #179 if everything's ok.