JuliaDynamics / InteractiveDynamics.jl

Fast, general-purpose interactive applications for complex systems
https://juliadynamics.github.io/InteractiveDynamics.jl/dev/
MIT License
171 stars 25 forks source link

CompatHelper: bump compat for Makie to 0.18, (keep existing compat) #113

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

This pull request changes the compat entry for the Makie package from 0.17 to 0.17, 0.18. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

Datseris commented 1 year ago

cc @fbanning , this Makie release had the bullet point:

Breaking Refactored DataInspector to use tooltip. This results in changes in the attributes of DataInspector. Added inspector_label, inspector_hover and inspector_clear as optional attributes https://github.com/JuliaPlots/Makie.jl/pull/2095.

(from https://github.com/MakieOrg/Makie.jl/blob/master/NEWS.md )

I am not sure if this broke, or unbroke, some behavior of the tooltip usage in the agent app. (I've merged this because this is a good release of Makie, with many new good features and performance improvements)

fbanning commented 1 year ago

Cool, nice to see some changes to DataInspector, it worked just fine before but was a bit hard to understand which attribute does what and that seems to have been tackled by the PR.

Did you test a simple inspection with our plot? Did you experience any problems? I've had a quick look through the list of changes and most of those attributes I didn't use in our relatively simple inspector function. If you didn't test anything at all, I'll try that.

Datseris commented 1 year ago

I didn't test something, but I also saw the changes and thought "Oh well, we probably didn't use that so it's probably okay"... :'D