search

JuliaDynamics / InteractiveDynamics.jl

Fast, general-purpose interactive applications for complex systems
https://juliadynamics.github.io/InteractiveDynamics.jl/dev/
MIT License
171 stars 25 forks source link

Fix inspection for Makie 0.18 #116

Closed fbanning closed 1 year ago

fbanning commented 1 year ago

Fixes issues with DataInspector from #113 which raised Makie compat to v0.18. This PR should cover all changes made to DataInspector. It now looks a lot nicer as well. :)

Screenshot_20221115_180155 Screenshot_20221115_180203

NB: This PR builds on top of the changes made in #114 and currently it's necessary to ]add OSMMakie#master to test this PR. It can only be merged once OSMMakie v0.0.6 is available on the public registry (it's registered and will be auto-merged with the next batch). To indicate this, I will leave this as a draft PR and only convert it to ready once the registry is updated.

fbanning commented 1 year ago

Ah nevermind, OSMMakie v0.0.6 is already published! 🎉 So this PR is good to go as well. :)

You OK with this, @Datseris ?

Datseris commented 1 year ago

Did you publish a new tag of InteractiveDynamics with this in? (patch number should have been incremented here, as no v1 exists yet)

fbanning commented 1 year ago

No I didn't because I merged it into the graphspace-support branch which already has an incremented version number. These should be published together.