JuliaDynamics / InteractiveDynamics.jl

Fast, general-purpose interactive applications for complex systems
https://juliadynamics.github.io/InteractiveDynamics.jl/dev/
MIT License
171 stars 25 forks source link

Update to Makie 0.17 #99

Closed Datseris closed 2 years ago

Datseris commented 2 years ago

Everything is up to date. There is one place we have problem. The inspection of agents (pop ups). At the moment I get an error I am not sure how to tackle, because it doesn't come from the source of InteractiveDynamics. The error is:

ERROR: type Array has no field extents
Stacktrace:
 [1] getproperty
   @ .\Base.jl:42 [inlined]
 [2] Bbox_from_glyphcollection(text::String, gc::Vector{Point{2, Float32}})
   @ Makie C:\Users\datse\.julia\packages\Makie\xVGV7\src\interaction\inspector.jl:191
 [3] (::Makie.var"#883#886"{Observable{Any}})(gc::Vector{Point{2, Float32}}, pos::Point{2, Float32}, pad::Vec{4, Float32})
   @ Makie C:\Users\datse\.julia\packages\Makie\xVGV7\src\interaction\inspector.jl:294
 [4] #map#19
   @ C:\Users\datse\.julia\packages\Observables\ynr7h\src\Observables.jl:444 [inlined]
 [5] map(::Makie.var"#883#886"{Observable{Any}}, ::Observable{Vector{Point{2, Float32}}}, ::Observable{Any}, ::Observable{Any})
   @ Observables C:\Users\datse\.julia\packages\Observables\ynr7h\src\Observables.jl:444
 [6] plot!(plot::Combined{Makie._inspector, Tuple{Int64}})
   @ Makie C:\Users\datse\.julia\packages\Makie\xVGV7\src\interaction\inspector.jl:293

Turning enable_inspection = false removes the error.

@fbanning do you have any idea here? You can use the Flocking example file and do enable_inspection = true to replicate.

fbanning commented 2 years ago

@fbanning do you have any idea here? You can use the Flocking example file and do enable_inspection = true to replicate.

Hm, an inspection error? Weird, I've only used what Makie provides via DataInspector. Maybe there's something messed up in the way the string for the tooltip box is created. I'll have a look.

fbanning commented 2 years ago

The issue is with Makie 0.17.7 and already being worked on. See https://github.com/JuliaPlots/Makie.jl/pull/2073