use the Base version of func_for_method_checked

JuliaDynamics / ResumableFunctions.jl

C# style generators a.k.a. semi-coroutines for Julia.

Other

160 stars 19 forks source link

use the Base version of func_for_method_checked #33

Closed KristofferC closed 5 years ago

KristofferC commented 5 years ago

This package was noted to fail on the 1.2 branch of Julia. The usage of func_for_method_checked was changed in https://github.com/JuliaLang/julia/pull/31025 to also take an sparams argument. The old usage was deprecated but the function depwarn is not available in Core.Compiler. Using the Base version of this function will show the deprecation message instead of hard errorring.

coveralls commented 5 years ago

Coverage increased (+0.7%) to 78.713% when pulling 35c9b520bb189576f7cc953d99559f47d45e7292 on KristofferC:patch-1 into c7bbd98dc11612521c1ea8d27bd23b9ebd4a78c1 on BenLauwens:master.

coveralls commented 5 years ago

Coverage increased (+0.7%) to 78.713% when pulling 35c9b520bb189576f7cc953d99559f47d45e7292 on KristofferC:patch-1 into c7bbd98dc11612521c1ea8d27bd23b9ebd4a78c1 on BenLauwens:master.

BenLauwens commented 5 years ago

Base version does not return the slottypes. I have merged manually the changes in the source. Thanks

Ben