search

JuliaDynamics / ResumableFunctions.jl

C# style generators a.k.a. semi-coroutines for Julia.
Other
160 stars 19 forks source link

polishing CI and tests #62

Closed Krastanov closed 1 year ago

Krastanov commented 1 year ago

This PR updates the CI, sets automatic updates for the CI and compat sections, adds static analysis tests, and restructures the tests to follow the SciML conventions (using SafeTestsets).

Edit: It also does doctests now and it tests back to 1.2, as well as some win/mac combinations.

Edit2: The type-dispatch tests were broken on 32bit architectures. That is fixed too now.

Krastanov commented 1 year ago

I will wait for a day or two and then merge this even without review. It contains only logistical fixes/updates/reorganization. Anyone, let me know if you would prefer that I wait on the merge.

gerlero commented 1 year ago

@Krastanov looks good!

I'm ignoring the AppVeyor failures since I assume those need to be fixed independently by @BenLauwens.

Incidentally, the README needs a small correction here:

https://github.com/BenLauwens/ResumableFunctions.jl/blob/e7fd5f0cb541911f2519133101232cce74fa1a1c/README.md?plain=1#L114

That should be changed to v0.6.1 v0.6.2, to match the version set in the Project.toml here, which has to be a patch release with the fix for #60. Maybe you can also make that change in this PR?

Besides that and as far as I'm concerned, LGTM and registered soon.

EDIT: v0.6.1 -> v0.6.2