Closed gerlero closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c4fc271
) 85.41% compared to head (7efd0f9
) 85.93%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@yieldfrom
is failing CI on Julia nightly but that looks like a different issue.
@marcom's code from #80 no longer fails with this branch, so I'll merge it soon unless someone objects.
Thanks for taking care of this! Could we give some time to Pepijn to respond with his plans, as he spearheaded these past improvements (and they are quite valuable)? It is holiday season right now so things can be a bit slow. If it is a quick fix we can just wait for that. If it is something he does not have the bandwidth for (perfectly understandable given that it is all volunteer efforts by everyone here), or if it is something that would take a while, we should proceed with this reversal.
However, could you please preserve the tests and mark them as @test_broken
? Even if we have to revert #76, we should not lose track of the issues Pepijn reported.
Apologies, I did not see the message Pepijn had posted on the other thread. Could you please preserve the tests (now @test_broken
) and I am happy to vote in favor of this being merged and released.
Could you please preserve the tests (now
@test_broken
)
Good call.
and I am happy to vote in favor of this being merged and released
Thanks. I'll take care of that and release a new patch version.
Reverts #76 due to #80.
@Krastanov @pepijndevos @marcom
EDIT: Fixes #80