Closed Krastanov closed 8 months ago
Attention: 21 lines
in your changes are missing coverage. Please review.
Comparison is base (
bd9557e
) 84.39% compared to head (6903679
) 81.29%.:exclamation: Current head 6903679 differs from pull request most recent head 5d147b5. Consider uploading reports for the commit 5d147b5 to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/macro.jl | 50.00% | 10 Missing :warning: |
src/safe_logging.jl | 30.76% | 9 Missing :warning: |
src/utils.jl | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is ready now. It is about 8 lines of new code (a very simple update to the macro), a lot of inline comments to document what was already there for the sake of new maintainers, and tests.
I will wait until late next week in case any worries come up in a review and I will then merge. Let me know if you want me to wait longer for a review (and if generally you prefer me to never merge anything without a review).
This is needed by QuantumSavory.jl
This builds upon #88 -- it is one single commit more. It will look much simpler after #88 is merged.
Fixes #77
I.e after this is merged we can do things like