Closed Keno closed 6 months ago
@Keno , I was a bit too trigger happy to merge this -- does it actually fix anything? There is no src
in this function, so I expect to just get an undefined variable error here.
Sorry, should be ci
of course. I must have gotten myself confused with another package.
And just to double check, any reason it is not @static if ...
? Not quite sure what are the rules here
@static
is fine, but shouldn't be required. The feature check will const fold, but even if it didn't, it's on the compile-time path, so it runs infrequently. Generally I don't use @static
unless there's some reason it's needed
noted, thanks!
Codecov Report
Attention: Patch coverage is
33.33333%
with2 lines
in your changes are missing coverage. Please review.Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #95 +/- ## ========================================== - Coverage 81.29% 80.95% -0.35% ========================================== Files 6 6 Lines 417 420 +3 ========================================== + Hits 339 340 +1 - Misses 78 80 +2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.