Closed JanJereczek closed 1 year ago
We will rework the significance tests because the same thing is happening in CausalityTools.jl so we want to stop re-inventing the wheel!
@JanJereczek see https://github.com/JuliaDynamics/TimeseriesSurrogates.jl/issues/142
This PR fixes the tests that were broken by #19
Additionally to that:
timeseries.jl
significant()
fixed when using::Sigma
(I think we might want to call this::ConfidenceIntervall
)indicators_significance()
wrong input type forq
(which we might want to rename as it does not have to be aQuantile
and might be confusing)equidistant_step()
. Commented out intest/timeseries.jl
.Apart from this: I really like the new code. I have a few minor questions to ask when we call next time but it was all very understandable :)