JuliaEarth / GeoStats.jl

An extensible framework for geospatial data science and geostatistical modeling fully written in Julia
https://juliaearth.github.io/GeoStatsDocs/stable/
MIT License
506 stars 61 forks source link

Fix viewer: constant columns with missing values #335

Closed eliascarv closed 10 months ago

eliascarv commented 10 months ago

MWE:

julia> a = [missing, 1.0, 1.0, missing]
4-element Vector{Union{Missing, Float64}}:
  missing
 1.0
 1.0
  missing

julia> b = [missing, 1, missing, 1]
4-element Vector{Union{Missing, Int64}}:
  missing
 1
  missing
 1

julia> gtb = georef((; a, b, c = a * u"m", d = b * u"m"), CartesianGrid(2, 2))
4×5 GeoTable over 2×2 CartesianGrid{2,Float64}
┌────────────┬─────────────┬────────────┬─────────────┬─────────────────────────────────────────┐
│     a      │      b      │     c      │      d      │                geometry                 │
│ Continuous │ Categorical │ Continuous │ Categorical │               Quadrangle                │
│ [NoUnits]  │  [NoUnits]  │    [m]     │     [m]     │                                         │
├────────────┼─────────────┼────────────┼─────────────┼─────────────────────────────────────────┤
│  missing   │   missing   │  missing   │   missing   │ Quadrangle((0.0, 0.0), ..., (0.0, 1.0)) │
│    1.0     │      1      │   1.0 m    │     1 m     │ Quadrangle((1.0, 0.0), ..., (1.0, 1.0)) │
│    1.0     │   missing   │   1.0 m    │   missing   │ Quadrangle((0.0, 1.0), ..., (0.0, 2.0)) │
│  missing   │      1      │  missing   │     1 m     │ Quadrangle((1.0, 1.0), ..., (1.0, 2.0)) │
└────────────┴─────────────┴────────────┴─────────────┴─────────────────────────────────────────┘

julia> viewer(gtb)
ERROR: ArgumentError: range step cannot be zero
Stacktrace:
...
codecov-commenter commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (113b425) 0.51% compared to head (d9693d9) 0.50%.

Files Patch % Lines
ext/viewer.jl 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #335 +/- ## ========================================= - Coverage 0.51% 0.50% -0.01% ========================================= Files 6 6 Lines 196 197 +1 ========================================= Hits 1 1 - Misses 195 196 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.