Closed evetion closed 11 months ago
You are taking a specific implementation of the interface, in this case a GeoInterface.Wrappers.Line and trying to prove a point about the interface, which is not valid. The GeoInterface.jl is still an interface with the issues raised in the book.
Congratulations on the book, it's looking very good! I'm looking forward to the sections still in progress.
While skimming along, I encountered the following in 3.3:
I agree with the overall point, generic representations of polygons from GIS are bad for any optimization. But I don't think the example make sense here, because GeoInterface can actually do what you want here, as it has a
TriangleTrait
, and we dispatch on it for things likenpoint
(https://juliageo.org/GeoInterface.jl/stable/guides/defaults/#Fallbacks). Besides, as an interface, it doesn't decide on how something should be represented in memory.Quick example for a LineString:
I would propose to remove the "like it's done in GeoInterface for example" from the sentence above. A replacement, if needed, could be like it's done in GIS/Simple Features representations (such as WKT/WKB, etc).